Messages in this thread | | | Date | Mon, 11 Mar 2002 17:58:41 -0700 | From | Erik Andersen <> | Subject | Re: [patch] My AMD IDE driver, v2.7 |
| |
On Mon Mar 11, 2002 at 07:34:26PM -0500, Jeff Garzik wrote: > Reason 1: Standard kernel convention. In other ioctls, we check basic > arguments and return EINVAL when they are wrong, even for privieleged > ioctls.
I have no argument with basic command validation. But take a look at ide_cmd_type_parser(), for example. Do we really need a giant switch statement listing all the allowed commands, just so we can throw back a IDE_DRIVE_TASK_INVALID to user-space if they decide to send down some undocumeted firmware wiping commands? Especially since that giant struct of allowed commands is duplicated in ide_pre_handler_parser() and ide_handler_parser()
-Erik
-- Erik B. Andersen http://codepoet-consulting.com/ --This message was written using 73% post-consumer electrons-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |