lkml.org 
[lkml]   [2002]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Various 802.1Q VLAN driver patches. [try2]
"David S. Miller" wrote:
>
> From: Andrew Morton <akpm@zip.com.au>
> Date: Fri, 01 Mar 2002 10:45:39 -0800
>
> +#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
>
> Is this avoidable somehow?
>
> It's stupid to have all the overhead when vlans aren't even
> being built into the kernel.
>
> That was my original impetus.
>
> It's costly in some cases, when you have the TXDs on the chip
> you can avoid an entire PIO for each packet.

I'm pretty sure Andrew realizes this. I can see two valid complaints,

1) you don't need ugly ifdefs in the code itself -- define a no-op
static inline function for when !VLAN

2) IIRC Alan or somebody is trying to get rid of CONFIG_xxx_MODULE,
because it doesn't really cover the case of when somebody builds VLAN
"later on" as a module, but disables it initially.

--
Jeff Garzik |
Building 1024 |
MandrakeSoft | Choose life.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:24    [W:0.117 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site