lkml.org 
[lkml]   [2002]   [Feb]   [9]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 9 Feb 2002 10:46:10 +0000 (GMT)
FromHugh Dickins <>
SubjectRe: [PATCH] __free_pages_ok oops
On Sat, 9 Feb 2002 alad@hss.hns.com wrote:
> 
> Is it possible to modify your patch from:
> 
> if (in_interrupt())
>    BUG();
> 
> to
> 
> if (unlikely(in_interrupt())
>     BUG();

Unlikely!

But seriously, that function is so full of checks for the improbable,
that it would seem a bit odd for me to add one just for this instance:
unless you've noticed that spectacularly bad code is generated here?

I think I'd prefer to blend in with the surroundings for now, and
leave it for, say, the ACME Janitorial Services to come along and
put BUG_ON()s throughout.

Hugh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:24    [from the cache]
©2003-2008