lkml.org 
[lkml]   [2002]   [Feb]   [28]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 28 Feb 2002 20:07:30 +0100
FromChristoph Hellwig <>
SubjectRe: vm-28 for 2.4.19pre1
Hi Andrea,

In article <20020228174607.X1705@inspiron.school.suse.de> you wrote:
> This patch includes all my latest VM developement against 2.4.19pre1. I
> would suggest it for inclusion in pre2. I don't have the time right now
> to split it into little pieces, but I can do that in the weekend or next
> week if you prefer (tomorrow I'll be offline).
>
> 	ftp://ftp.us.kernel.org/pub/linux/kernel/people/andrea/patches/v2.4/2.4.19pre1/vm-28

Could you actually explain what it changes, especially as it isn't
really commented very well..

Despite of the above I already have some nitpicks:

 - couldn't you make inc_nr_active_pages/dec_nr_active_pages/
	inc_nr_inactive_pages/dec_nr_inactive_pages inlines?
   The current macro abuse isn't nice.
 - in mm/memory.c (the 1141 chunk) you introduced a race.


-- 
Of course it doesn't work. We've performed a software upgrade.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:20    [from the cache]
©2003-2008