lkml.org 
[lkml]   [2002]   [Feb]   [24]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSun, 24 Feb 2002 18:18:15 +0100 (CET)
FromJaroslav Kysela <>
SubjectRe: KMOD error messages - proposal and patch
On Sun, 24 Feb 2002, Alan Cox wrote:

> > +	/* Don't allow request_module() when ramfs based rootfs is mounted! */
> > +	if ( ! strcmp("rootfs", current->fs->pwdmnt->mnt_sb->s_type->name) ) {
> > +		printk(KERN_ERR "request_module[%s]: Real root fs not mounted\n",
> > +			module_name);
> > +		return -EPERM;
> > +	}
>
> The ramfs based root file system once the load ramfs from tar stuff is
> working may have a completely valid modprobe on it.
>
> Perhaps request_module() needs a 'quiet' flag

Well, I though about this, but we can suppress with this way important
informative error messages as well. I think that the condition in kmod
might be exteded in future when the ramfs initialization will be
implemented.

						Jaroslav

-----
Jaroslav Kysela <perex@suse.cz>
Linux Kernel Sound Maintainer
ALSA Project  http://www.alsa-project.org
SuSE Linux    http://www.suse.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:24    [W:0.105 / U:0.010 seconds]
©2003-2008 Jasper Spaans