Messages in this thread | | | From | Jes Sorensen <> | Date | Fri, 22 Feb 2002 10:34:13 -0500 | Subject | Re: [PATCH] bring sanity to div64.h and do_div usage |
| |
>>>>> "Jeff" == Jeff Garzik <jgarzik@mandrakesoft.com> writes:
Jeff> Jes Sorensen wrote: >> Why? CONFIG_$ARCH only makes sense if you can enable two >> architectures in the same build. What does CONFIG_M68K give you that >> __mc68000__ doesn't provide?
Jeff> 1) it is a Linux kernel standard. all arches save two define Jeff> CONFIG_$arch.
Ehm, what standard? the standard way has always been ARCH==, CONFIG_PPC used to be the only place using this and all it did was to make things uglier and inconsistent.
Jeff> 2) you have two tests, "ARCH==m68k" in config.in and "__mc68000__" Jeff> in C code. CONFIG_M68K means you only test one symbol, the same Jeff> symbol, in all code.
If you want to do that, then one should use CONFIG_<ARCH> in the Makefiles as well.
Jeff> 3) as this thread shows, due to #1, users -expect- that Jeff> CONFIG_M68K will exist
Ehm, most kernel developers will expect ARCH== in Config.in as thats how it's always been.
Jes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |