lkml.org 
[lkml]   [2002]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: another IDE cleanup: kill duplicated code
    Andrew Morton wrote:

    >Martin Dalecki wrote:
    >
    >>If you are already at it, I would like to ask to you consider seriously
    >>the removal of the
    >>following entries in the ide drivers /proc control files:
    >>
    >> ide_add_setting(drive, "breada_readahead", ... 1,
    >>2, &read_ahead[major], NULL);
    >> ide_add_setting(drive, "file_readahead", ...
    >>&max_readahead[major][minor], NULL);
    >>
    >>Those calls can be found in ide-cd.c, ide-disk,c and ide-floppy.c
    >>
    >
    >I suspect that if we remove these, we'll one day end up putting them back.
    >It is appropriate that we be able to control readahead characteristics
    >on a per-device and per-technology basis.
    >
    You are missing one simple thing: The removed values doen't control
    ANYTHING!


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:24    [W:0.021 / U:36.360 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site