Messages in this thread | | | Date | Thu, 5 Dec 2002 03:41:18 -0800 | From | William Lee Irwin III <> | Subject | Re: [warnings] [2/8] fix uninitialized quot in drivers/serial/core.c |
| |
On Thu, Dec 05, 2002 at 02:52:59AM -0800, wli@holomorphy.com wrote: >> Give quot a default value so it's initialized. rmk, this is yours >> to ack.
On Thu, Dec 05, 2002 at 11:19:13AM +0000, Russell King wrote: > Why can't we get this obvious compiler bug fixed? I'd rather have > the compiler bug fixed rather than trying to work around the bogus > warning. > It's obvious that the loop: > for (try = 0; try < 3; try++) > is going to be executed at least once, which will initialise quot. > As for the second hunk, its correct in so far as it'll catch the case > where we can't even do 9600 baud. However, I think we should just > bound the lowest baud rate such that we can always do 9600 baud (and > therefore this function will never return zero.)
Linus, please count this as a NAK wrt. the serial changes in this set. They'll be dealt with at the toolchain level.
Thanks, Bill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |