Messages in this thread | | | Date | Wed, 04 Dec 2002 18:03:05 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] 2.4.20 cciss patch 01 - adds support for the SA641, SA642 and SA6400 controllers. |
| |
White, Charles wrote: > linux-2.4.20.cciss_p01/drivers/block/cciss.c > --- linux-2.4.20.orig/drivers/block/cciss.c Thu Nov 28 18:53:12 2002 > +++ linux-2.4.20.cciss_p01/drivers/block/cciss.c Wed Dec 4 > 15:09:39 2002 > @@ -56,6 +56,11 @@ > #include "cciss.h" > #include <linux/cciss_ioctl.h> > > +/* remove when PCI_DEVICE_ID_COMPAQ_CCISSC is in pci_ids.h */ > +#ifndef PCI_DEVICE_ID_COMPAQ_CCISSC > +#define PCI_DEVICE_ID_COMPAQ_CCISSC 0x46 > +#endif > +
the patch looks simple and obvious, though I have one objection: as the comment indicates, this patch hunk should instead be in include/linux/pci_ids.h. There is no rule against modifying pci_ids.h -- please do so, and not crap up drivers with tons of these ifdefs...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |