lkml.org 
[lkml]   [2002]   [Dec]   [31]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 31 Dec 2002 11:17:49 -0800 (PST)
FromLinus Torvalds <>
SubjectRe: [PATCH] 2.5: make gigabit ethernet into a real submenu
On Tue, 31 Dec 2002, Tomas Szepe wrote:
> > The attached unidiff creates a parent entry for all gigabit ethernet
> interfaces, making the submenu consistent with that of 10/100.  Suggested
> by Robert P. J. Day.  Trivial patch against 2.5-bkcurrent.

Hmm.. Wouldn't it be nicer to instead of :

   ...
	 menu "Ethernet (1000 Mbit)"
	        depends on NETDEVICES

	+config NET_GIGABIT_ETH
	+       bool "Ethernet (1000 Mbit)"
	+       ---help---
	+         Ethernet (also called IEEE 802.3 or ISO 8802-2) is the most common
   ...

have

   ...
	+config NET_GIGABIT_ETH
        +       bool "Ethernet (1000 Mbit)"
	+	depends on NETDEVICES
        +       ---help---
        +         Ethernet (also called IEEE 802.3 or ISO 8802-2) is the most common
	   ... 
	menu "Ethernet (1000 Mbit)" 
		depends on NET_GIGABIT_ETH
   ...
so that the you don't even see the things if you don't select for them?

Untested, but it would seem to be the more natural approach..

		Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:32    [from the cache]
©2003-2008