lkml.org 
[lkml]   [2002]   [Dec]   [25]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 25 Dec 2002 19:45:01 -0800 (PST)
From"Randy.Dunlap" <>
SubjectRe: [PATCH] dev_printk macro
On 25 Dec 2002, Alan Cox wrote:

| On Mon, 2002-12-23 at 00:46, Randy.Dunlap wrote:
| >
| > I'm glad to see this patch available, as Greg was.
| > Now I have some questions about it.
| >
| > a.  Is it only for drivers?  If so, why?
| >     Filesystems and other subsystems that are not drivers could use
| >     something like this also.
|
| Definitely - fs_printk, inode_printk etc may all make sense
| >
| > b.  Is it only for drivers that have a device?
| >     What does a driver use for dev_printk() if it doesn't have a <dev>?
| >     However, these do cover the large majority of cases, so that's good.
|
| This case isnt covered. All devices should eventually have a dev right
| 8)

Eventually, but not always.  Anyway, after another day or 2 to
reflect on it, I'll withdraw the comment I made about checking
<dev> for NULL in those macros.  They can/should be context-sensitive.

-- 
~Randy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:31    [from the cache]
©2003-2008