[lkml]   [2002]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [Linux-fbdev-devel] Re: xxx_check_var
    On Tue, 10 Dec 2002, James Simmons wrote:
    > > > When I look at atyfb_check_var or aty128fb_check_var, I see that they
    > > > will alter the contents of *info->par. Isn't this a bad thing? My
    > >
    > > Yes, this wrong, and afaik, it's your original port to 2.5 that did that
    > > ;)
    > Yeap. The idea of check_var is to validate a mode. Note modedb uses just
    > check_var. It is okay to READ the values in your par. You shouldn't alter
    > the values in par.

    Perhaps it makes sense to make the info parameter of fb_check_var() const to
    prevent this from happening?



    Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:31    [W:0.017 / U:144.268 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site