lkml.org 
[lkml]   [2002]   [Dec]   [21]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 21 Dec 2002 09:57:42 -0800
FromJohn Reiser <>
SubjectRe: vt8235 fix, hopefully last variant
Looking at the important piece:
-----
> +	/* Always use 4 address setup clocks on ATAPI devices */
> +	if (drive->media != ide_disk)
> +		t.setup = 4;
-----
it seems to me that using 4 for t.setup also should be done unless _all_ devices
on that cable are ide_disk.  In particular, if one device is ide_disk but the
other is not, then "t.setup = 4;" should be used even when talking to the ide_disk.
Otherwise the non-ide_disk device might get confused, respond when it should not,
and garble the transaction.  Or, is such a bad thing prevented in some other way?
-- 
John Reiser, jreiser@BitWagon.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:31    [W:0.496 / U:0.040 seconds]
©2003-2008 Jasper Spaans