lkml.org 
[lkml]   [2002]   [Dec]   [13]   [last100]   RSS Feed
Views: [more markup]   [less markup]   [headers]   [forward]  
 
Messages in this thread
/
SubjectRe: 2.5.5[01]]: Xircom Cardbus broken (PCI resource collisions)
FromArjan van de Ven <>
Date13 Dec 2002 11:10:24 +0100
On Thu, 2002-12-12 at 23:47, Valdis.Kletnieks@vt.edu wrote:

> Been there. Done that. Does the attached patch help? It did for me.
> 
> /Valdis
> 
> 
> ----
> 

> --- drivers/pcmcia/cardbus.c.dist	2002-12-03 01:49:29.000000000 -0500
> +++ drivers/pcmcia/cardbus.c	2002-12-03 01:50:23.000000000 -0500
> @@ -283,8 +283,6 @@
>  		dev->hdr_type = hdr & 0x7f;
> 
>  		pci_setup_device(dev);
> -		if (pci_enable_device(dev))
> -			continue;
> 
>  		strcpy(dev->dev.bus_id, dev->slot_name);
> 
> @@ -302,6 +300,8 @@
>  			pci_writeb(dev, PCI_INTERRUPT_LINE, irq);
>  		}
> 
> +		if (pci_enable_device(dev))
> +			continue;
>  		device_register(&dev->dev);
>  		pci_insert_device(dev, bus);
>  	}

interesting. BUT aren't we writing to the device 3 lines before where
you add the pci_enable_device()? That sounds like a bad plan to me ;(
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 11:31    [W:0.390 / U:1.890 seconds]
©2003-2008 Jasper Spaans