lkml.org 
[lkml]   [2002]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectPrintout improvements in ide-tape
    This one changes printouts only. It is not as important as the
    one I sent before it, but it was very helpful in debugging.
    I think we better have this one too.

    -- Pete

    --- linux-2.4.20-ac2/drivers/ide/ide-tape.c Fri Dec 13 16:55:13 2002
    +++ linux-2.4.20-ac2-pb/drivers/ide/ide-tape.c Fri Dec 13 18:12:20 2002
    @@ -2165,11 +2163,6 @@
    status.b.check = 0;
    if (status.b.check || test_bit(PC_DMA_ERROR, &pc->flags)) {
    /* Error detected */
    -#if IDETAPE_DEBUG_LOG
    - if (tape->debug_level >= 1)
    - printk(KERN_INFO "ide-tape: %s: I/O error\n",
    - tape->name);
    -#endif /* IDETAPE_DEBUG_LOG */
    if (pc->c[0] == IDETAPE_REQUEST_SENSE_CMD) {
    printk(KERN_ERR "ide-tape: I/O error in "
    "request sense command\n");
    @@ -2270,8 +2263,8 @@
    pc->current_position += bcount.all;
    #if IDETAPE_DEBUG_LOG
    if (tape->debug_level >= 2)
    - printk(KERN_INFO "ide-tape: [cmd %x] transferred %d bytes "
    - "on that interrupt\n", pc->c[0], bcount.all);
    + printk(KERN_INFO "ide-tape: [cmd %x] done %d\n"
    + pc->c[0], bcount.all);
    #endif
    if (HWGROUP(drive)->handler != NULL)
    BUG();
    @@ -2614,8 +2607,11 @@
    if (status.b.dsc) {
    if (status.b.check) {
    /* Error detected */
    - printk(KERN_ERR "ide-tape: %s: I/O error, ",
    - tape->name);
    + printk(KERN_ERR "ide-tape: %s: I/O error: "
    + "pc = %2x, key = %2x, asc = %2x, ascq = %2x\n",
    + tape->name, pc->c[0],
    + tape->sense_key, tape->asc, tape->ascq);
    +
    /* Retry operation */
    return idetape_retry_pc(drive);
    }
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 13:31    [W:0.021 / U:66.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site