Messages in this thread | | | Date | Wed, 11 Dec 2002 20:58:54 -0500 | From | David Dawes <> | Subject | Re: [Dri-devel] Re: 2.4.20 AGP for I845 wrong ? |
| |
On Wed, Dec 11, 2002 at 01:07:45PM +0100, Nicolas ASPERT wrote: >Margit Schubert-While wrote: >> From drivers/char/agp/agpgart_be.c >> 4554,4559 >> { PCI_DEVICE_ID_INTEL_845_G_0, >> PCI_VENDOR_ID_INTEL, >> INTEL_I845_G, >> "Intel", >> "i845G", >> intel_830mp_setup }, >> >> Surely this is wrong or ? >> Should be "intel_845_setup", I think. >> > >IIRC, the 845G is a "new" version of the 830MP chipset (it had been >added by Abraham vd Merwe & Graeme Fisher some months ago), but acts >basically just as the 830MP. Therefore the entry is correct.... Or maybe >if it gets confusing adding a comment would not hurt...
No, I think it should be intel_845_setup too, since the 845G docs on Intel's public web site show that the behaviour is like the 845 when the on-board graphics isn't enabled. I made that change in my locally maintained version of the agpgart driver a little while ago, but haven't had the opportunity to test it with an external AGP card in an 845G box yet.
David -- David Dawes Release Engineer/Architect The XFree86 Project www.XFree86.org/~dawes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |