lkml.org 
[lkml]   [2002]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Alsa-devel] Re: [2.4]ALi M5451 sound hangs on init; workaround
At Wed, 11 Dec 2002 08:52:42 -0800,
Fedor Karpelevitch wrote:
>
> > > I have ALi M5451 souncard in my laptop (Compaq Presario 900z for
> > > those searching) and it hangs the machine with any kernel I tried
> > > (currently 2.4.20-ac1 + hirofumi patch). I traced it down to the
> > > line where it hangs - that is drivers/sound/trident.c:3379 which
> > > says: pci_write_config_byte(pci_dev, 0xB8, ~temp);
> >
> > Looking at the docs it looks like the code Matt Wu added may have
> > been meant to do
> >
> > pci_read_config_byte(pci_dev, 0x59, temp)
> > temp &= ~0x80
> > pci_write...
> >
>
> just to make sure I got it right, is the following what you suggest?
> (pseudo-patch):
>
> --------
> static int ali_close_multi_channels(void)
> {
> char temp = 0;
> struct pci_dev *pci_dev = NULL;
>
> pci_dev =pci_find_device(PCI_VENDOR_ID_AL,PCI_DEVICE_ID_AL_M1533,
> pci_dev);
> if (pci_dev == NULL)
> return -1;
> - temp = 0x80;
> + pci_read_config_byte(pci_dev, 0x59, temp);
> + temp &= ~0x80;
> - pci_write_config_byte(pci_dev, 0x59, ~temp);
> + pci_write_config_byte(pci_dev, 0x59, temp);
>
> pci_dev = pci_find_device(PCI_VENDOR_ID_AL,
> PCI_DEVICE_ID_AL_M7101, pci_dev);
> if (pci_dev == NULL)
> return -1;
>
> - temp = 0x20;
> + pci_read_config_byte(pci_dev, 0xB8, temp);
> + temp &= ~0x20
> - pci_write_config_byte(pci_dev, 0xB8, ~temp); // the line I
> + pci_write_config_byte(pci_dev, 0xB8, temp); //commented out
>
> return 0;
> }
> ---------------------

and don't forget to change similary for ali_setup_multi_channels(),
too.

> >
> > (Ditto with fixing setup_multi_cannnels)
> >


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:31    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site