Messages in this thread | | | Date | Sun, 1 Dec 2002 11:25:32 -0800 | From | Greg KH <> | Subject | Re: [RFC] LSM fix for stupid "empty" functions |
| |
On Mon, Dec 02, 2002 at 04:46:43AM +1100, James Morris wrote: > On Sun, 1 Dec 2002, Greg KH wrote: > > > On Sun, Dec 01, 2002 at 05:59:10PM +0100, Olaf Dietsche wrote: > > > > VERIFY_STRUCT(struct security_operations, ops, err); > > > > > > This shouldn't be necessary anymore. > > > > Good point, I'll remove it. It was a hack anyway :) > > > > I think we still want to make sure that the module author has explicitly > accounted for all of the hooks, in case new hooks are added.
But with this patch, if the module author hasn't specified a hook, they get the "dummy" ones. So the structure should always be full of pointers, making the VERIFY_STRUCT macro pointless.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |