Messages in this thread | | | Date | Fri, 8 Nov 2002 15:22:55 +0100 (MET) | From | Geert Uytterhoeven <> | Subject | Re: [PATCH] SCSI on non-ISA systems |
| |
On Fri, 8 Nov 2002, Russell King wrote: > On Fri, Nov 08, 2002 at 02:46:40PM +0100, Geert Uytterhoeven wrote: > > Since 2.5.31, the compilation of kernel/dma.c is conditional on > > CONFIG_GENERIC_ISA_DMA. However, drivers/scsi/hosts.c unconditionally calls > > free_dma(), which breaks machines with SCSI that don't have ISA. > > This isn't actually the original purpose of CONFIG_GENERIC_ISA_DMA (it > was to allow an architecture to provide ISA-like DMA without having to > use the ISA DMA request/free functions - eg, they need to claim interrupts > on request_dma() and free them on free_dma()).
Then what's the correct(TM) fix? Unconditionally #define CONFIG_GENERIC_ISA_DMA, so it behaves like before?
> However, since this function isn't used on ARM, it doesn't affect me, > and so I don't have any problem with this patch. 8)
Hehe ;-)
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |