Messages in this thread | | | Date | Fri, 8 Nov 2002 13:21:27 +0100 (MET) | From | "Maciej W. Rozycki" <> | Subject | Re: [PATCH][2.5-AC] Forced enable/disable local APIC |
| |
On Thu, 7 Nov 2002, Zwane Mwaikambo wrote:
> > No. Read what I wrote: if cpu_has_apic is false, the code drops into > > the "try the hard way by messing with the APICBASE MSR". Your "force" > > goto bypasses the CPU checks, which are there to ensure that the CPU > > actually _has_ an APICBASE MSR. > > My mistake, i misread. > > > I still see no reason at all for the force. > > I agree, in which case the first patch should make everyone happy. If Alan > doesn't take it for his next release i'll resend.
Well, the "lapic" option should override the DMI setting, not the APICBASE availability check. Anyway, I don't insist on this that much -- while I think consistency is good, none of the "*apic" options are actually a necessity for me. If one needs the option, one may still cook an appropriate patch oneself.
-- + Maciej W. Rozycki, Technical University of Gdansk, Poland + +--------------------------------------------------------------+ + e-mail: macro@ds2.pg.gda.pl, PGP key available +
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |