Messages in this thread | | | From | Bernd Eckenfels <> | Subject | Re: [PATCH] C99 initializers for drivers/media/radio | Date | Sat, 30 Nov 2002 22:01:39 +0100 |
| |
In article <20021130174509.GD10613@debian> you wrote: > Here's a patch set for switching drivers/media/radio to use C99 > initializers. The patches are against 2.5.50. ... > static struct pcm20_device pcm20_unit = { > - freq: 87*16000, > - muted: 1, > - stereo: 0 > + .freq = 87*16000, > + .muted = 1, > }; ...
IMHO it is not a good idea to skip default initilised members. IT is self documenting to see all members, and it is easier to change them, if required. Especially if the old code had it.
Greetings Bernd -- eckes privat - http://www.eckes.org/ Project Freefire - http://www.freefire.org/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |