Messages in this thread Patch in this message | | | Date | Tue, 19 Nov 2002 20:38:57 +0100 | From | "Juan M. de la Torre" <> | Subject | [PATCH] sys_init_module refuses to load module without init code/data sections |
| |
load_module() stores in mod->init_size the size of init data and init code sections, and later allocs (using module_alloc()) mod->init_size bytes.
If the module has not init data and init code sections mod->init_size is 0, so module_alloc() will return NULL and load_module() will abort loading the module with -ENOMEM.
Possible patch attached, sorry if this is a known issue.
Best regards, Juanma
--- linux-2.5.48/kernel/module.c.orig Tue Nov 19 20:08:52 2002 +++ linux-2.5.48/kernel/module.c Tue Nov 19 20:37:47 2002 @@ -972,13 +972,15 @@ memset(ptr, 0, mod->core_size); mod->module_core = ptr;
- ptr = module_alloc(mod->init_size); - if (!ptr) { - err = -ENOMEM; - goto free_core; - } - memset(ptr, 0, mod->init_size); - mod->module_init = ptr; + if (mod->init_size) { + ptr = module_alloc(mod->init_size); + if (!ptr) { + err = -ENOMEM; + goto free_core; + } + memset(ptr, 0, mod->init_size); + mod->module_init = ptr; + }
/* Transfer each section which requires ALLOC, and set sh_offset fields to absolute addresses. */ -- /jm
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |