lkml.org 
[lkml]   [2002]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subjectlinux-2.4.18-modified-scsi-h.patch

Greetings Doug et al.

Please consider the addition of this simple void ptr to the scsi_request
struct. The addition of this simple void pointer allows one to map any
and all request execution caller the facility to search for a specific
operation without having to run in circles. Hunting for these details
over the global device list of all HBA's is silly and one of the key
reasons why there error recovery path is so painful.


Scsi_Request *req = sc_cmd->sc_request;
blah_blah_t *trace = NULL;

trace = (blah_blah_t *)req->trace_ptr;


Therefore the specific transport invoking operations via the midlayer will
have the ablity to track and trace any operation.

It will save everyone headaches.

Cheers,


Andre Hedrick, CTO & Founder
iSCSI Software Solutions Provider
http://www.PyXTechnologies.com/
--- linux/drivers/scsi/scsi.h.orig 2002-10-31 01:45:39.000000000 -0800
+++ linux/drivers/scsi/scsi.h 2002-10-31 01:46:31.000000000 -0800
@@ -667,8 +667,11 @@
unsigned short sr_sglist_len; /* size of malloc'd scatter-gather list */
unsigned sr_underflow; /* Return error if less than
this amount is transferred */
+ void *trace_ptr; /* capable of cmd-cmnd-error tracing */
};

+#define MODIFIED_SCSI_H
+
/*
* FIXME(eric) - one of the great regrets that I have is that I failed to define
* these structure elements as something like sc_foo instead of foo. This would
\
 
 \ /
  Last update: 2005-03-22 13:31    [from the cache]
©2003-2011 Jasper Spaans