Messages in this thread | | | Date | Tue, 19 Nov 2002 14:55:02 +0000 | From | Russell King <> | Subject | Re: Patch: module-init-tools-0.6/modprobe.c - support subdirectories |
| |
On Tue, Nov 19, 2002 at 05:42:38PM +1100, Rusty Russell wrote: > A: The total linking code is about 200 generic lines, 100 > x86-specific lines.
Should we be bounds-checking the relocations? Maybe we are (I'm not familiar enough with this new module code yet.) I'm specifically thinking about the following:
/* This is where to make the change */ location = (void *)sechdrs[sechdrs[relsec].sh_info].sh_offset + rel[i].r_offset; /* This is the symbol it is referring to */ sym = (Elf32_Sym *)sechdrs[symindex].sh_offset + ELF32_R_SYM(rel[i].r_info); if (!sym->st_value) {
-- Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |