Messages in this thread | | | Date | Sat, 16 Nov 2002 16:24:24 -0500 | From | Jeff Garzik <> | Subject | Re: Patch: linux-2.5.47/arch/alpha/kernel/pci.c - do not directly set pci_dev.dma_mask where possible |
| |
Adam J. Richter wrote:
> --- linux-2.5.47/arch/alpha/kernel/pci.c 2002-11-10 19:28:03.000000000 > -0800 > +++ linux/arch/alpha/kernel/pci.c 2002-11-16 05:54:00.000000000 -0800 > @@ -124,7 +124,7 @@ > unsigned int class = dev->class >> 8; > > if (class == PCI_CLASS_BRIDGE_ISA || class == PCI_CLASS_BRIDGE_ISA) { > - dev->dma_mask = MAX_ISA_DMA_ADDRESS - 1; > + pci_set_dma_mask(dev, MAX_ISA_DMA_ADDRESS - 1); > isa_bridge = dev; > } > }
No; pci_set_dma_mask is too high-level for the above arch-specific code. When dma_mask is moved this will need to get examined and fixed up in another way.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |