Messages in this thread | | | Date | Thu, 14 Nov 2002 13:28:13 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] eliminate pci_dev name |
| |
Matthew Wilcox wrote:
> diff -urpNX dontdiff linux-2.5.47/include/linux/pci.h > linux-2.5.47-willy/include/linux/pci.h > --- linux-2.5.47/include/linux/pci.h 2002-11-14 10:52:17.000000000 -0500 > +++ linux-2.5.47-willy/include/linux/pci.h 2002-11-14 > 11:43:40.000000000 -0500 > @@ -371,7 +371,6 @@ struct pci_dev { > struct resource dma_resource[DEVICE_COUNT_DMA]; > struct resource irq_resource[DEVICE_COUNT_IRQ]; > > - char name[90]; /* device name */ > char slot_name[8]; /* slot name */ > int active; /* ISAPnP: device is active */ > int ro; /* ISAPnP: read only */ >
Patch looks pretty good to me... seems like the obvious (and useful) cleanup.
You should increase DEVICE_NAME_SIZE in include/linux/device.h from 80 to 90, though. I assume you don't want to take the other option, which is to audit every use and all the id strings to make sure they're short enough. In fact, IIRC, device name increased in size due to some really long PCI names, so I think '90' will wind up the preferred value in any case.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |