Messages in this thread | | | Date | Wed, 13 Nov 2002 12:17:45 +0100 | Subject | linux/elf.h vs linux/module.h [was: 2.5-bk AT_GID clash] | From | Anders Gustafsson <> |
| |
On Wed, Nov 13, 2002 at 05:07:03AM +1100, Rusty Russell wrote: > In message <1037122398.27014.43.camel@jen.americas.sgi.com> you write: > > On Tue, 2002-11-12 at 11:16, Rusty Russell wrote: > > > This might be kOK too, but in practice I don't think much will be in > > > moduleloader.h: asm/module.h only really defines struct > > > mod_arch_specific, which is embedded in struct module, and struct > > > module needs to be exposed for those inlines... > > > > But does everyone who wants to implement a module need to be exposed > > to all the details of the elf header? > > Well, linux/module.h -> asm/module.h -> linux/elf.h. Although if you > use #define instead of typedef you can break the last link. Feel free > to send a patch to split it into moduleload.h or something, but I > think it'll look tiny.
At least for i386 there is no inclusion of elf.h from asm/module.h, and they are already defines. And a quick grep in the other arches shows no direct include of elf.h. So removing elf.h from module.h should relieve all sourcefiles[*] including module.h implicitly including elf.h too, which imho is a good thing.
[*] find . -name "*.c" | xargs grep "include <linux/module.h>" | wc -l 2479
-- Anders Gustafsson - andersg@0x63.nu - http://0x63.nu/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |