lkml.org 
[lkml]   [2002]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] NCR53C9x ESP: C99 designated initializers
From
Date
On Mon, 2002-11-11 at 17:24, Linus Torvalds wrote:
>
> On 11 Nov 2002, Alan Cox wrote:
> >
> > The stupid thing is we take the lock then call the eh function then drop
> > it. You can drop the lock, wait and retake it. I need to fix a couple of
> > other drivers to do a proper wait and in much the same way.
>
> Hmm.. I wonder if the thing should disable the queue (plug it) and release
> the lock before calling reset. I assume we don't want any new requests at
> this point anyway, and having the low-level drivers know about stopping
> the queue etc sounds like a bad idea..

Thats already being dealt with. The eh handler is a seperate thread
called after things are reasonably sane so that it can attempt recovery
and do so in a sleeping context if need be. The eh ones are actually
very except for the fact they take the lock before calling

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:30    [W:0.085 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site