Messages in this thread |  | | | Date | Tue, 8 Oct 2002 15:21:02 -0300 (BRT) | | From | Rik van Riel <> | | Subject | Re: [RFC] [PATCH 1/4] Add extended attributes to ext2/3 |
| |
On Tue, 8 Oct 2002 tytso@mit.edu wrote:
> This first patch creates a generic interface for registering caches with > the VM subsystem so that they can react appropriately to memory > pressure.
> +/* BKL must be held */
... but it isn't. Also, kswapd isn't holding the bkl while traversing the list.
> +void register_cache(struct cache_definition *cache) > +{ > + list_add(&cache->link, &cache_definitions); > +}
I suspect you'll want a semaphore for the cache_definitions list.
cheers,
Rik -- A: No. Q: Should I include quotations after my reply?
http://www.surriel.com/ http://distro.conectiva.com/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |