Messages in this thread | | | Date | Thu, 3 Oct 2002 17:42:07 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH] Start of cleaning up socket ioctls |
| |
On Thu, Oct 03, 2002 at 04:23:19PM +0100, Alan Cox wrote: > Nice but one request - can you call the protocol handlers first and if > they return -ENOTTY then call the default ones provided by the upper > layer. That will let you remove even more common code to most versions, > make it work like the serial and other layers do, and still let people > override defaults
I'm trying to tread as lightly as possible at first. I wasn't sure how well this kind of cleanup would be received ;-) The trouble with doing what you've asked immediately is that not all ->ioctl methods return -ENOTTY. Some return -EINVAL, some return -EOPNOTSUPP and some return -ENOPKG. Yeah, this should probably get cleaned up, but baby steps first. I have no Grand Plan here, but I do want to make things a little more understandable before I embark on anything bigger.
-- Revolutions do not require corporate support. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |