Messages in this thread | | | Subject | Re: Linux 2.5.40-ac1 | From | Alan Cox <> | Date | 03 Oct 2002 16:17:36 +0100 |
| |
On Thu, 2002-10-03 at 15:45, Manfred Spraul wrote: > > o Fix abuse of set_bit in winbond-840 (me) > > Were there bug reports, Have you tested the change?
Yes and no - I don't have an 840
> I think the cpu_to_le32 is wrong. > > On big endian computers, the nic is set into a big-endian mode, and it > did work with set_bit on my power mac. Unfortunately, I don't have > access to it right now.
The checks I did were that it seemed to produce the same data in both cases. So if it was wrong before (using set_bit) its probably wrong now.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |