Messages in this thread | | | Date | Sun, 27 Oct 2002 19:26:40 -0500 | From | Jeff Garzik <> | Subject | Re: PATCH: Support PCI device sorting (Re: PCI device order problem) |
| |
H. J. Lu wrote:
>On Sun, Oct 27, 2002 at 09:42:49AM -0800, Greg KH wrote: > > >>On Sat, Oct 26, 2002 at 05:25:26PM -0700, H. J. Lu wrote: >> >> >>>On Sat, Oct 26, 2002 at 08:05:13PM -0400, Jeff Garzik wrote: >>> >>> >>>>Jeff Garzik wrote: >>>> >>>> >>>> >>>>>s/__devinit/__init/ and the implementation looks ok to me >>>>> >>>>> >>>> >>>>...except if your patch can be called in hotplug paths... >>>> >>>> >>>There are plenty of __devini in arch/i386/kernel/pci-pc.c. I will leave >>>mine alone. >>> >>> >>That is because those functions can be called in PCI hotplug paths, >>since yours is only called during init, it should be marked as such. >> >> >> > >Are you telling me that pcibios_sort will be called by PCI hotplug? > >
no, he's saying __init is correct, as Alan and I said.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |