Messages in this thread | | | Date | Fri, 25 Oct 2002 20:04:45 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] hyper-threading information in /proc/cpuinfo |
| |
Dave Jones wrote:
>On Fri, Oct 25, 2002 at 05:30:19PM -0400, Robert Love wrote: > > > +#ifdef CONFIG_SMP > > + if (cpu_has_ht) { > > + seq_printf(m, "physical processor ID\t: %d\n", phys_proc_id[n]); > > + seq_printf(m, "number of siblings\t: %d\n", smp_num_siblings); > > + } > > +#endif > >Something else looks suspect to me here. >smp_num_siblings is going to say the same value on every CPU in the >system. It's questionable whether we want to print it out n times. > >
Not really... we print out other information that is duplicated N times, because it is the common case that N-way systems have matched processors with matched capabilities. The above caught my eye as well, but the alternative is to subvert the standard /proc/cpuinfo format and print something out only once, that clearly applies to each processor.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |