Messages in this thread Patch in this message |  | | | Date | Fri, 25 Oct 2002 16:48:44 +0200 | | From | Jens Axboe <> | | Subject | Re: [Bug] 2.5.44-ac2 cdrom eject panic |
| |
On Fri, Oct 25 2002, Jens Axboe wrote: > On Fri, Oct 25 2002, Nyk Tarr wrote: > > On Fri, Oct 25, 2002 at 12:39:38PM +0200, Jens Axboe wrote: > > > On Fri, Oct 25 2002, Nyk Tarr wrote: > > > > > > > > Hi, > > > > > > > > I got this nice error after doing an 'eject /cdrom' > > > > > > [snip] > > > > > > 2.5.44 and thus 2.5.44-acX has seriously broken REQ_BLOCK_PC, so it's no > > > wonder that it breaks hard. Alan, I can sync the sgio patches for you if > > > you want. > > > > > > Nyk, if you could try > > > > > > *.kernel.org/pub/linux/kernel/people/axboe/patches/v2.5/2.5.44/sgio-15.bz2 > > > > > > that would be great, thanks. > > > > This also seems to hang and die. No panic in the logs this time, but > > some stuff scrolling off the screen on console. Sadly I've nothing to > > use as serial console at the mo' but I'll try some other options... > > Please try sgio-16 from the above location. Ejecting works fine for me, > it even manages to close the tray when I ask it to.
Irk you are on SCSI, yes you need this incremental patch for that to work. Sorry about that, I've put up 16b which contains this.
--- drivers/block/scsi_ioctl.c~ 2002-10-25 16:46:58.000000000 +0200 +++ drivers/block/scsi_ioctl.c 2002-10-25 16:47:32.000000000 +0200 @@ -319,6 +319,8 @@ case CDROMEJECT: rq = blk_get_request(q, WRITE, __GFP_WAIT); rq->flags = REQ_BLOCK_PC; + rq->rq_dev = to_kdev_t(bdev->bd_dev); + rq->rq_disk = bdev->bd_disk; rq->data = NULL; rq->data_len = 0; rq->timeout = BLK_DEFAULT_TIMEOUT; -- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |