lkml.org 
[lkml]   [2002]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] NMI request/release, version 5 - I think this one's ready
John Levon wrote:

>On Thu, Oct 24, 2002 at 08:28:20AM -0500, Corey Minyard wrote:
>
>
>
>>diff -ur linux.orig/arch/i386/kernel/traps.c linux/arch/i386/kernel/traps.c
>>--- linux.orig/arch/i386/kernel/traps.c Mon Oct 21 13:25:45 2002
>>+++ linux/arch/i386/kernel/traps.c Thu Oct 24 08:11:14 2002
>>
>>
>
>At this point I'd quite like to see :
>
> mv nmi.c nmi_watchdog.c
>
>and put all this stuff in always-compiled nmi.c. traps.c is getting
>bloated.
>
I agree.

>
>
>
>> static void default_do_nmi(struct pt_regs * regs)
>> {
>> unsigned char reason = inb(0x61);
>>
>> if (!(reason & 0xc0)) {
>>-#if CONFIG_X86_LOCAL_APIC
>> /*
>>- * Ok, so this is none of the documented NMI sources,
>>- * so it must be the NMI watchdog.
>>+ * Check the handler list to see if anyone can handle this
>>+ * nmi.
>> */
>>- if (nmi_watchdog) {
>>- nmi_watchdog_tick(regs);
>>+ if (call_nmi_handlers(regs))
>>
>>
>
>Now you're using RCU, it's a real pity that we have the inb() first -
>if it wasn't for that, there would be no reason at all to have the "fast
>path" setting code too (the latter code is ugly, which is one reason I
>want to ditch it).
>
>How about adding default_do_nmi as the minimal-priority handler, then
>add the watchdog with higher priority above that ? Then oprofile can add
>itself on top of those both and return NOTIFY_OK to indicate it should
>break out of the loop. As a bonus, you lose the inb() for the watchdog
>too.
>
Is there any way to detect if the nmi watchdog actually caused the
timeout? I don't understand the hardware well enough to do it without
some work, but it would be a VERY good idea to make sure the nmi
watchdog actully caused the operation.

Plus, can't you get more than one cause of an NMI? Shouldn't you check
them all?

>>+++ linux/include/asm-i386/irq.h Wed Oct 23 16:47:24 2002
>>
>>
>
>I thought you agreed the stuff should be in asm/nmi.h ?
>
I will (I had forgotten), and I will move nmi.h to nmi_watchdog.h.

-Corey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:30    [W:0.148 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site