Messages in this thread | | | Date | Tue, 22 Oct 2002 10:37:01 -0700 | From | Tim Hockin <> | Subject | Re: [BK PATCH 1/4] fix NGROUPS hard limit (resend) |
| |
Alan Cox wrote: > On Tue, 2002-10-22 at 18:26, Tim Hockin wrote: > >>Alan Cox wrote: >> >>>Ok sanity check time. Why do you need qsort and bsearch for this kind of >>>thing. Just how many groups do you plan to support ? >> >>Unlimited - we've tested with tens of thousands. > > > Now how about the real world requirements ?
Those were real world requirements - we got the number 10,000 from our product management, which (presumably) spoke with customers. On the hosting systems, it is really possible to have thousands of virtual sites.
Now, I don't much care if you want it to be a linear search, and I'll revert it, if needed, but qsort() is already in in XFS specific code, and bsearch is small. It doesn't negatively impact any fast path, and provides better behavior for the crazies that really want 10,000 groups.
Tim
-- Tim Hockin Systems Software Engineer Sun Microsystems, Linux Kernel Engineering thockin@sun.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |