Messages in this thread | | | Subject | Re: [PATCH] [2.4.20-pre10] dpt_i2o fix | From | Alan Cox <> | Date | 21 Oct 2002 10:52:12 +0100 |
| |
On Tue, 2002-10-15 at 14:40, Ducrot Bruno wrote: > The first chunk of attached patch alloc wait_data with > kmalloc(..., GFP_ATOMIC) instead of GPF_KERNEL > in the function adpt_i2o_post_wait() because this function > is called in the function adpt_i2o_passthru() (line 1717 or > so) but with a spin_lock held.
Given the nature of the usage I think its probably better to fix it properly than to just hack it up to be GFP_ATOMIC. If the caller was to pass in the wait_data buffer then the problem could be fixed cleanly
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |