Messages in this thread | | | Date | Thu, 17 Oct 2002 15:39:50 -0700 | From | Andrew Morton <> | Subject | Re: 2.5.41 still not testable by end users |
| |
Thomas Molina wrote: > > ... > > > Oct 16 21:40:59 declan kernel: [__might_sleep+84/96] > > > ... > > > Oct 16 21:41:00 declan kernel: [init_irq+637/820] init_irq+0x27d/0x334 > > > > > > > One day. Before we all die. Please. > > I had that as fixed in my problem list. It should have been integrated by > 2.5.42, certainly 2.5.43. I'm not seeing any additional reports since > then.
Oh. We still have:
if (request_irq(hwif->irq,&ide_intr,sa,hwif->name,hwgroup)) { if (!match) kfree(hwgroup); spin_unlock_irqrestore(&ide_lock, flags);
request_irq() was changed to use GFP_ATOMIC, so it's "fixed".
But only for i386.
request_irq() inside spinlock is a *very* common bug. Moreso as people move cli()-using code across to use spinlocks.
And we've just lost our ability to detect this bug.
request_irq() needs to take the allocation mode as an argument. Should always have. Sigh. I'll fix it up sometime. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |