Messages in this thread | | | Subject | Re: [PATCH] pre-decoded wchan output | From | Robert Love <> | Date | 17 Oct 2002 16:04:36 -0400 |
| |
On Thu, 2002-10-17 at 15:58, Christoph Hellwig wrote:
> Can't you just left the old, nuerical one in even if CONFIG_KALLSYMS > ise set? One ifdef less and far less surprises..
But why? Save the call to get_wchan()...
Ideally I would like to remove the field altogether but thats too much breakage.
A value of zero in the field position is an indication the wchan file exists, too.
The ifdefs there do not bother me. I think its pretty clear why its being done, although I could add a comment to the "0UL" value saying "now in /proc/#/wchan" or whatever.
But, no, I do not agree. No human can parse /proc/#/stats anyhow. Since procps needs to be updated for 3.0 anyhow, it will be fine.
Robert Love
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |