[lkml]   [2002]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH]: linux-2.5.42uc1 (MMU-less support)
    On Wed, Oct 16, 2002 at 01:25:49AM +1000, Greg Ungerer wrote:
    > Hi All,
    > An updated uClinux patch is available at:
    > Changelog:
    > 1. v850 update

    There are a bunch of CVS .#* files left from this one.
    v850_defs.h wants updating to the generic generate-asm-offsets.h
    mechanism (check the toplevel Makefile)
    Please stop the ugly symlink hell with the linker scripts -
    we have for that.
    it should read something like:

    #include <linux/config.h>
    #ifdef BOARD1
    #include ""

    for v850

    Could you please explain the rootfs hacks in v850?
    I don't think we want those in mainline but rather generic

    Also please remove arch/v850/sim/* - that stuff doesn't
    belong into the kernel tree.

    > 2. cleaned up mm/page_alloc.c

    Why do you put set_page_refs into a header? Separating it out
    looks good to me, but IMHO it should stay in page_alloc.c.
    BTW, are you sure that you don't need to set the refs in the
    other caller of prep_new_page? To me it looks like you should
    and then you could merge it into prep_new_page.

    Also, what is CONFIG_CONTIGUOUS_PAGE_ALLOC doing? It seems not
    fully implemented but adds lots of uglieness :)
    CONFIG_NO_MMU_LARGE_ALLOCS might want a saner name, btw

    General commets:
    - files have three-space, not two-space indentation
    - I don't think you want to keep around the old binfmt_flat
    format when merghin into mainline
    - MAX_SHARED_LIBS is never used
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:30    [W:0.024 / U:18.640 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site