lkml.org 
[lkml]   [2002]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.5.41 capget fix

On Thu, 10 Oct 2002, Chris Wright wrote:
>
> The patch below fixes my oversight. The locking is left the way it was,
> and just the pid 0 part is fixed as well as the duplicate code removed.

All right, call me stupid, but twhere is the "duplication" in the code you
removed?

I see the "security/capability.c" thing, yes, but I also look at
"security/dummy.c", and it appears that at least for that case nobody
would ever initialize the capabilities that we return to user space at
all.

So there's a bug somewhere there, and removing the duplication makes
things worse (admittedly for a case which isn't enabled in the regular
kernel, but still..)

So I'd ask you to have patience with me, and send a third patch that gets
this thing right too..

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:29    [W:0.066 / U:0.516 seconds]
©2003-2011 Jasper Spaans. Advertise on this site