Messages in this thread | | | Date | Thu, 10 Oct 2002 12:43:31 -0700 | From | William Lee Irwin III <> | Subject | Re: [LART] inode mismanagement in hugetlb code |
| |
Alexander Viro wrote: >> a) inodes MUST have an address of valid struct super_block in their >> ->i_sb. Had been discussed quite a few times already.
On Thu, Oct 10, 2002 at 12:22:28PM -0700, Andrew Morton wrote: > afaict, that code only wants an inode because it is borrowing > the pagecache functions for page lookup. It's using i_ino as > a search key too. It has no superblock. > Solutions might be: 1) allocate a private <int key, radix tree> > structure or 2) require that these inodes come from hugetlbfs, > although the "key" makes that a bit tricky.
shm clobbers hugetlbfs-assigned inode numbers with the shp->id somewhere around newseg(), (which doesn't matter because it's the only user of the kern_mounted fs) so ->i_ino will need to avoid clashing there. But there are several ways to wean hugetlbpage.c off ->i_ino so it's not a big deal.
Bill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |