Messages in this thread | | | Date | Wed, 9 Jan 2002 14:26:57 -0800 | From | Greg KH <> | Subject | Re: __FUNCTION__ - patch for USB |
| |
On Thu, Jan 10, 2002 at 12:12:29AM +0200, Vladimir Kondratiev wrote: > Hello, > Since I have started this thread, I feel I have to do something real. > Dummy technical work, but someone have to do it, right? > I patched USB subsystem, it uses __FUNCTION__ in deprecated way no more. > What is changed? > - in usb.h, I modified dbg(), warn(), err(), info() macros to contain > function name in the prefix. These macros are for simple one-line messages. > - in all files under drivers/usb, all macros mentioned fixed. > - all __FUNCTION__ occurencies in drivers/usb revised. > > I compiled kednel with all USB modules enabled. Since everything > compiles OK and all changes are in message formats, this patch should > not corrupt anything. In the worst case you will get badly formatted > message.
Your patch makes whitespace changes to a lot of dbg() statements, but does not modify their contents. Can you please change this, as this change does not need to happen.
> Patch is against 2.4.17
2.4.18-pre2 has a _lot_ of usb changes and this patch misses a number of places.
I'd also like to see this against the 2.5.x tree first, as the recommended compiler for the 2.4.x tree is still 2.95.3, and I don't think that will change anytime soon.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |