Messages in this thread | | | Date | Wed, 09 Jan 2002 12:14:28 -0500 | From | Chris Mason <> | Subject | Re: [reiserfs-dev] [PATCH] UUID & volume labels support for reiserfs |
| |
On Wednesday, January 09, 2002 07:44:30 PM +0300 Oleg Drokin <green@namesys.com> wrote:
> Does filling something with zeroes counts as "using the field"? ;)
We must be reading different versions of generate_random_uuid ;-)
> >> The point is that we should never add something to the kernel until our >> utils package understands it. Yes, this is a simple case, but if we want > In fact, current reiserfsprogs understands these fields (look into the > the struct super_block definition in reiserfsprogs). It just cannot > change content of the fields.
/* Structure of super block on disk */ struct reiserfs_super_block { /* 0 */ struct reiserfs_super_block_v1 s_v1; /* 76 */ char sb_mnt_version[16]; /* 92 */ char sb_mkfs_version[16]; /*108 */ char sb_fsck_version[16]; /*124 */ char sb_unused[204-16-16-16-SB_SIZE_V1] ; /* zero filled by mkreiserfs */ };
Show me the part where it knows what a uuid is. It should at least be able to show the uuid set by the kernel.
Please don't take this the wrong way, this is a good (and simple) patch that adds a cool feature. We just need to do a better job of having the utils support the features before sending the patch it. It does a better job of proving we've tested the feature and that kernel patch fully meets our needs.
-chris
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |