![]() | ||||||||||
Messages in this thread |
Doug Ledford wrote: > Doug Ledford wrote: > > >>> Fixes it applies except for the SiS integration: >>> * drain_dac >>> Use interruptible_sleep_on_timeout instead of schedule_timeout. >>> I think this is cleaner. >> >> >> >> >> This is fine. > > > > Oops, this is one of the mistakes Ben pointed out to me. > interruptible_sleep_on_timeout(wait_queue head, timeout) overwrites the > wait queue that we've already added ourselves to. schedule_timeout() > does the right thing here. (interruptible_sleep_on_timeout doesn't > really buy us much of anything we care about either, so it's find to > stay with schedule_timeout) > > > > OK, various clean ups made, and enough of the SiS code included that I think it should work, plus one change to the i810 interrupt handler that will (hopefully) render the other change you made to get_dma_addr and drain_dac unnecessary. If people could please download and test the new 0.14 version of the driver on my site, I would appreciate it. http://people.redhat.com/dledford/i810_audio.c.gz -- Doug Ledford <dledford@redhat.com> http://people.redhat.com/dledford Please check my web site for aic7xxx updates/answers before e-mailing me about problems - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | |||||||||
| Last update: 2005-03-22 11:15 [W:0.507 / U:0.060 seconds] ©2003-2008 Jasper Spaans | ||||||||||