lkml.org 
[lkml]   [2002]   [Jan]   [8]   [last100]   RSS Feed
Views: [more markup]   [less markup]   [headers]   [forward]  
 
Messages in this thread
/
DateTue, 08 Jan 2002 03:11:25 -0500
FromDoug Ledford <>
SubjectRe: i810_audio
Doug Ledford wrote:


>> Fixes it applies except for the SiS integration:
>> * drain_dac
>>   Use interruptible_sleep_on_timeout instead of schedule_timeout.
>>   I think this is cleaner. 
> 
> 
> 
> This is fine.


Oops, this is one of the mistakes Ben pointed out to me. 
interruptible_sleep_on_timeout(wait_queue head, timeout) overwrites the wait 
queue that we've already added ourselves to.  schedule_timeout() does the 
right thing here.  (interruptible_sleep_on_timeout doesn't really buy us 
much of anything we care about either, so it's find to stay with 
schedule_timeout)




-- 

  Doug Ledford <dledford@redhat.com>  http://people.redhat.com/dledford
       Please check my web site for aic7xxx updates/answers before
                       e-mailing me about problems

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 11:15    [from the cache]
©2003-2008