lkml.org 
[lkml]   [2002]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] truncate fixes
    Andrea Arcangeli wrote:
    >
    > I prefer my fix that simply recalls the ->truncate callback if -ENOSPC
    > is returned by prepare_write. vmtruncate seems way overkill,

    No opinion on that here. This is what was in -ac. Perhaps Al can
    comment?

    > and after
    > calling ->truncate the __block_prepare_changes above won't be necessary
    > because the leftover will be correctly deallocated (no need to clear
    > them out and to mark them dirty, they will just go away before any
    > readpage can see them).

    No, this code is needed if the write is _inside_ i_size, to an
    uninstantiated block. truncate won't remove those blocks, and we've
    gone and added them to the file.

    -
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:15    [W:0.020 / U:0.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site