lkml.org 
[lkml]   [2002]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [CFT] [JANITORIAL] Unbork fs.h
Date
On January 4, 2002 11:20 pm, Andreas Dilger wrote:
> On Jan 04, 2002 15:16 +0000, Andries.Brouwer@cwi.nl wrote:
> > sizeof (foo): 1611, sizeof(foo): 19364 => -bs should be removed
> >
> > int
> > foo(int x): 11408, int foo(int x): 57275 => -psl should be removed
> >
> > I do not think good style is best defined by majority vote.
>
> Certainly not. However, the Lindent style I'm trying to achieve is that
> dictated by Linus. However, CodingStyle doesn't give all of the details
> of how code should be formatted, so I have to look at the code to see
> what is actually there.
>
> > (void *) foo: 11274, (void *)foo: 17062 => -ncs should be added
> >
> > Read old kernel sources.
> >
> > de = (struct minix_dir_entry *) (offset + bh->b_data);
> >
> > :"S" ((long) name),"D" ((long) buffer),"c" (len)
> >
> > if (32 != sizeof (struct minix_inode))
>
> Well, that's what I was trying to do when I found out that lksr.org
> (hosted by innominate.de) was not available. It seems the -ncs
> change is incorrect then (although my preference is to add it - there
> doesn't seem to me to be any benefit of having the extra space).

Thomas Graichen told me that lksr.org will be back up 'soon'. Innominate.org
is back up, run by Gerrit Pape, one of a group of Berliners who call
themselves 'exnominate' (that would include me). In fact, innominate itself
is back, but that's a whole nuther story.

p.s., if Andries is right - and he probably is - then it looks like Linus's
habitual style is 'space after cast' and 'space after sizeof'. We could
always ask.

If we put enough work into lindent, maybe we'll come up with a Linusbot?

--
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:15    [W:0.080 / U:0.196 seconds]
©2003-2014 Jasper Spaans. Advertise on this site