Messages in this thread | | | Date | Fri, 4 Jan 2002 01:59:10 -0700 | From | Andreas Dilger <> | Subject | Re: [CFT] [JANITORIAL] Unbork fs.h |
| |
OK, for people that care, I did a quick survey of the changes I made. My idea is to conform to what is the current "standard" coding style, and not necessarily what was thrown into Lindent, so that running Lindent on sources will change as little as is necessary to make it "standard".
I also checked the l-k archives a bit to confirm the changes match the formatting of the examples given by the King Penguin.
Sadly, lksr is not responding, so I can't look at the history of changes to Lindent. Is there another kernel CVS with CVSWeb that was as complete as lksr?
On Jan 04, 2002 08:05 +0100, Daniel Phillips wrote: > On January 3, 2002 08:36 pm, Andreas Dilger wrote: > > I removed the following two options: > > -bs: Put a space between sizeof and its argument.
grep -r "sizeof (" linux | wc -l, grep -r "sizeof(" linux | wc -l:
sizeof (foo): 1611, sizeof(foo): 19364 => -bs should be removed
> > -psl: Put the type of a procedure on the line before its name.
grep -r -B2 "^{" linux | grep "^[^ ]*(" | wc -l, grep -r -B2 "^{" linux | grep "^.* .*(" | wc -l:
int foo(int x): 11408, int foo(int x): 57275 => -psl should be removed
> > I added the following options: > > -nbbo: don't prefer to break lines before boolean operators
grep -r "[&|][&|][ ^I]*$" | wc -l, grep -r "^[ ^I]*[&|][&|]" | wc -l:
&& foo): 3338, (foo &&: 12003 => -nbbo should be added
> > -ci8: indent continuation lines 8 characters
Hard to measure.
> > -ncs: Do not put a space after cast operators.
grep -r "\*) [a-z_(]" . | wc -l, grep -r "\*)[a-z_(]" . | wc -l:
(void *) foo: 11274, (void *)foo: 17062 => -ncs should be added
> Not putting a space after a cast is gross ;)
Well, it seems you are in the (slight) minority on this one. It's not as big a margin as the other ones, but still measurable. I wasn't able to find any examples from the King Penguin himself on this one. Maybe that means casts are evil and we should strive to rid the world of them? ;-)
Cheers, Andreas -- Andreas Dilger http://sourceforge.net/projects/ext2resize/ http://www-mddsp.enel.ucalgary.ca/People/adilger/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |