lkml.org 
[lkml]   [2002]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] amiga input api drivers
    Hi,

    James Simmons wrote:

    > + printk(amikbd_messages[scancode]); /* scancodes >= 0x78 are error codes */

    Damn, Geert was faster with this. :)

    > + for (i = 0; i < 0x78; i++)
    > + if (amikbd_keycode[i])
    > + set_bit(amikbd_keycode[i], amikbd_dev.keybit);

    Do I understand it correctly, that amikbd_keycode[i] must have non zero
    value for a valid key? If yes, something must be wrong here:

    > +static unsigned char amikbd_keycode[0x78] = {
    > + 0, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 43, 0, 82,

    0 is a valid keycode on the Amiga, it should be KEY_GRAVE.

    bye, Roman
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:16    [W:0.022 / U:0.300 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site